Ticket #50 (closed compito: sistemata)

Opened 4 years ago

Last modified 3 years ago

Esaminare il primo merge con il ramo seldon-dev

Reported by: fero Owned by:
Priority: importante Milestone: ACQUISTIAMO - L'utente può ordinare
Component: sviluppo Keywords:
Cc:

Description

Merge branch 'seldon-dev'


Opened questions:


  • plural with "s" instead of "_set" (i.e: products instead of product_set) does not match proposed GUIDELINES. Update GUIDELINES needed?
  • Look at the following two lines: I think the first is better because it uses model instance as it is intended to be used:
    • price_percent_update = self.gas.supplier_set.get(supplier=self.supplier).price_percent_update + price_percent_update = GASSupplierSolidalPact.objects.get(gas=self.gas, supplier=self.supplier).order_price_percent_update
    Take a look at merged files with grep -r "=self" * to spot the lines involved

Change History

comment:1 Changed 3 years ago by fero

  • Status changed from new to closed
  • Resolution set to sistemata

Fixed and updated GUIDELINES some time ago

Note: See TracTickets for help on using tickets.